[PLT-0] Fix race conditions in test_task_filter and test_data_row_delete_and_create_with_same_global_key#2047
Merged
mrobers1982 merged 1 commit intodevelopfrom Mar 18, 2026
Conversation
…create_with_same_global_key
lb-pno
changed the title
mrobers1982
approved these changes
Mar 18, 2026
mrobers1982
requested review from
StepanTytaLabelbox,
gmadaan-hue,
golchin-shahriar,
john-labelbox,
manuaero,
snmodi21 and
vedsirdeshmukh
mrobers1982
deleted the
pnoirel/PLT-0-fix-race-conditions-in-flaky-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_task_filterrace condition where the export task completes before the In_Progress query runs or the GraphQL query times out. Adds retry logic with a fallback to verify completion, and increases the wait timeout to 600s.test_data_row_delete_and_create_with_same_global_keyrace condition wherewait_till_done()silently returns after exhausting its 300s timeout.Introduces a
_wait_for_taskhelper with a 600s timeout, a defensive refresh, and an explicit completion assertion.Fixes # (issue)
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features
Note
Low Risk
Low risk because changes are confined to test code, but they may slightly increase CI runtime due to added retries and longer timeouts.
Overview
Improves test robustness around asynchronous task state transitions.
test_task_filternow retries querying forIn_Progresstasks (tolerating transient query errors), waits up to 600s for completion, and falls back to asserting the task ultimately reachesCOMPLETEif it was never observed in progress.test_data_row_delete_and_create_with_same_global_keyintroduces a_wait_for_taskhelper that uses a 600s timeout, refreshes if the task remainsIN_PROGRESS, and asserts completion to prevent silent timeouts from masking failures.Written by Cursor Bugbot for commit fcf02d9. This will update automatically on new commits. Configure here.